-
Notifications
You must be signed in to change notification settings - Fork 395
refactored CF bar to use flexbox instead of columns. This should clea… #2358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactored CF bar to use flexbox instead of columns. This should clea… #2358
Conversation
…r up issues on ultra large screens
|
🙈 The PR is closed and the preview is expired. |
|
@insectengine the screenshots you shared look fine - I would agree that even while many might have super-wide screens, we don't usually show the browser on full-screen so don't spend too much time on this.
Personally I think it would be fine to cap the width in case of it getting just too much, but I wonder what happens on high dpi screens? I don't have one of those - is that possibly why some folks wanted it to fill? |
|
I haven't looked at the changes yet, but last week I was thinking "should I suggest to @insectengine that flexbox makes everything better? No, Holly, don't do that, James has lots of things to be doing without refactoring column layouts away just because they're not the current fashion ... " So I'm happy to see this change arrived without me even having to irritate anyone :) |
|
Should we merge this? |
Just looking now! |






This should clear up issues on ultra large screens but I have no way to test this locally.